Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading templates from remote locations #123

Open
montmanu opened this issue Dec 10, 2019 · 1 comment
Open

Add support for loading templates from remote locations #123

montmanu opened this issue Dec 10, 2019 · 1 comment

Comments

@montmanu
Copy link
Contributor

montmanu commented Dec 10, 2019

Is your feature request related to a problem?

Currently, the plugin requires that resource manifest templates exist on disk:

drone-gke/main.go

Lines 516 to 524 in 6ac83b9

_, err := os.Stat(t)
if os.IsNotExist(err) {
if t == c.String("kube-template") {
return nil, fmt.Errorf("Error finding template: %s\n", err)
}
log("Warning: skipping optional template %s because it was not found\n", t)
continue
}

This complicates sharing / re-use of templates.

Describe the solution you'd like

An ideal implementation would support loading of resource manifest templates from a remote location; similar to kubectl apply [-f|-k]

Describe alternatives you've considered

Current alternatives / workarounds include:

  • pre-fetching remote manifest templates at build time (e.g., via curl, git submodules, etc)
  • use of kubectl / kustomize native features (instead of plugin)

Additional context

Any implementation of this feature request should consider potential interactions with #105 (i.e., how to load multiple templates from a remote location .. especially in the case of supporting directories as a valid argument)

@tonglil
Copy link
Member

tonglil commented Apr 24, 2020

I think this should be done in from a separate step.
That step can download any templates and concatenate them together for templating and application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants