Adding new pages titles #181, preview for candidate ERC #151 and disable synchronized scrolling #183 #191
Conversation
|
@Fmazin if you want to close multiple issues, you must add a "closing keyword" in front of each issue number:
|
There was a problem hiding this comment.
@Fmazin Overall, I like the changes and how they are implemented. Thank you. I agree with the most hints from Daniel, could u revise them. I found another improvement, which I would like to talk with you. Plese contact me over Mattermost.
Fmazin
changed the title
|
I have updated the look of the preview notice a little bit. |
ui/src/components/erc/erc.css
Outdated
|
|
||
| #PreviewNotice { | ||
| color: white; | ||
| background-color: #CE5100; |
There was a problem hiding this comment.
You added the color here again as css. It is also possible to use the color, specified in the theme.js. This would be the better way. Because If we want to change the color, we just have to change the color at one place and not in every css file. I just have inspected the UI and saw that there is also some code implemented this way. I have created a new issues #197, maybe we can postpone this and check, update the whole UI afterwards.
|
The changes from the chat are included. Thanks! During the review, I recognized two further possible improvements. The first would good to change before the merge. The other one is a general problem within the UI. I have created a further issue #197 for this. |
This PR should resolve #181 and close #151. It will also resolve #183.