Expand Linux disk for 3p package environments #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Chang <[email protected]>
This update makes it straightforward to build O3DE applications for Meta Quest devices, because the developer is not required anymore to download and decompress the `Oculus OpenXR Mobile SDK`. To understand this change, let's review a little bit of history: When making O3DE apps for Meta Quest devices, the developer was instructed to manually download and decompress the `Oculus OpenXR Mobile SDK` into a particular directory of the `OpenXRVk` Gem. Those instructions worked well until SDK v62. Starting SDK v63+ (It's currently at v72) Meta stopped distributing pre-compiled OpenXR Loader libraries, and now applications are simply required to get the OpenXR Loader directly from github: https://github.com/KhronosGroup/OpenXR-SDK In particular, this PR picks version 1.1.41 because that's the version used by `v72` of `Oculus OpenXR Mobile SDK`. In other words, with this change, OpenXR is now supported in its purest form, because there are no custom steps for a particular vendor. Also, it was found that when creating the Android package, the Android-tool.cmake tool doesn't copy the headers in the "install" directories. So I added an improvement to the `pull_and_build_from_git.py` script, where the `"extra_files_to_copy"` property now supports copying directories, with a third, optional, parameter, which is a list of file patterns to ignore when deepcopying the directories. Example: ```json { "extra_files_to_copy": [ ["temp/src/include", "OpenXR/include", ["*.txt", "*.license"]] ], } ``` Additionally, when copying files, it now supports automatic creation of non-existing sub-folders. --------- Signed-off-by: galibzon <[email protected]>
Signed-off-by: Mike Chang <[email protected]>
spham-amzn
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a disk resizing workflow to the packaging environment. This will increase the root disk size to 20GB and remove non-essential packages
Tested in my own branch with the OpenXR package: https://github.com/amzn-changml/3p-package-source/actions/runs/13618717178