Skip to content

Commit

Permalink
Increase resolution to 100% native + update foveation levels to be mo…
Browse files Browse the repository at this point in the history 
…re aggressive (#281)

* Increased the level of foviation. Before this change effect was too subtle.

Signed-off-by: moudgils <[email protected]>

* Fix tabs

Signed-off-by: moudgils <[email protected]>

---------

Signed-off-by: moudgils <[email protected]>
  • Loading branch information
@moudgils
moudgils authored Apr 20, 2023
1 parent ae3cab3 commit 506397b
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 46 deletions.
84 changes: 40 additions & 44 deletions Gems/XR/Code/Source/XRSystem.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ namespace XR
constexpr uint32_t gridSize = 8;
AZStd::vector<uint8_t> shadingRatePatternData(bufferSize);
AZ::RHI::ShadingRate rateGrid[gridSize][gridSize];
// Initialize the whole image with the normal rate
// Initialize the whole image with the normal rate. FYI - memset only works with 0 (i.e Rate1x1).
::memset(rateGrid, static_cast<int>(AZ::RHI::ShadingRate::Rate1x1), sizeof(rateGrid));

// Helper function to fill up the grid
Expand All @@ -507,7 +507,7 @@ namespace XR
for (int ii = row; ii < row + rowCount; ++ii)
{
rateGrid[i][ii] = supportedRates[static_cast<uint32_t>(rate)];
// The image is symetric on the vertical axis
// The image is symmetric on the vertical axis
rateGrid[gridSize - 1 - i][ii] = supportedRates[static_cast<uint32_t>(rate)];
}
}
Expand All @@ -519,64 +519,60 @@ namespace XR
case AZ::RHI::XRFoveatedLevel::Low:
{
// _______________________________________________
// |____2x2____|__________2x1__________|____2x2____|
// | | | |
// | | | |
// | | | |
// | 1x2 | 1x1 | 1x2 |
// | | | |
// |_____|___________________________________|_____|
// |_2x2_|____2x1____|____1x1____|____2x1____|_2x2_|
//
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 0, 0, 2, 1);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 0, gridSize - 1, 1, 1);
fillFunc(AZ::RHI::ShadingRate::Rate2x1, 2, 0, 2, 1);
fillFunc(AZ::RHI::ShadingRate::Rate2x1, 1, gridSize - 1, 2, 1);
fillFunc(AZ::RHI::ShadingRate::Rate1x2, 0, 1, 1, gridSize - 2);
}
break;
case AZ::RHI::XRFoveatedLevel::Medium:
{
// _______________________________________________
// |_4x2_|________________2x2________________|_4x2_|
// |_4x4_|________________2x2________________|_4x4_|
// | | 1x2 | | 1x2 | |
// | |_____| |_____| |
// | | | |
// | 2x2 | 1x1 | 2x2 |
// | | | |
// | |___________________________________| |
// |___________|__________2x1__________|___________|
// |______________________2x2______________________|
//
fillFunc(AZ::RHI::ShadingRate::Rate4x2, 0, 0, 1, 1);
fillFunc(AZ::RHI::ShadingRate::Rate4x4, 0, 0, 1, 1);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 1, 0, 3, 1);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 0, 1, 1, gridSize - 1);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 1, gridSize - 1, 1, 1);
fillFunc(AZ::RHI::ShadingRate::Rate1x2, 1, 1, 1, 2);
fillFunc(AZ::RHI::ShadingRate::Rate2x1, 2, gridSize - 1, 2, 1);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 1, gridSize - 1, 3, 1);
}
break;
case AZ::RHI::XRFoveatedLevel::High:
case AZ::RHI::XRFoveatedLevel::Medium:
{
// 1 2 3 4 5 6 7 8
// _______________________________________________
// |_4x4_|____4x2____|____2x2____|____4x2____|_4x4_|
// | 2x4 |_2x2_| |_2x2_| 2x4 |
// |_____|_____| |_____|_____|
// | | | | | |
// | 2x2 | 1x2 | 1x1 | 1x2 | 2x2 |
// | | | | | |
// |_____|_____|_______________________|_____|_____|
// |_2x4_|____2x2____|____2x1____|____2x2____|_2x4_|
// |______4x4_______|____2x2____|____4x4___________| 1
// | | | | | | 2
// | | | | | | 3
// | 4x4 | 2x2 | | 2x2 | 4x4 | 4
// | | | 1x1 | | | 5
// | | | | | | 6
// |_____|_____|_______________________|_____|_____| 7
// |_______4x4______|____2x2____|____4x4___________| 8
//
fillFunc(AZ::RHI::ShadingRate::Rate4x4, 0, 0, 1, 1);
fillFunc(AZ::RHI::ShadingRate::Rate4x2, 1, 0, 2, 1);
fillFunc(AZ::RHI::ShadingRate::Rate2x4, 0, 1, 1, 2);
fillFunc(AZ::RHI::ShadingRate::Rate2x4, 0, gridSize - 1, 1, 1);
fillFunc(AZ::RHI::ShadingRate::Rate4x4, 0, 0, 3, 1);
fillFunc(AZ::RHI::ShadingRate::Rate4x4, 0, 1, 1, 6);
fillFunc(AZ::RHI::ShadingRate::Rate4x4, 0, gridSize - 1, 3, 1);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 1, 1, 1, 6);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 3, 0, 1, 1);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 1, 1, 1, 2);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 0, 3, 1, 4);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 1, gridSize - 1, 2, 1);
fillFunc(AZ::RHI::ShadingRate::Rate1x2, 1, 3, 1, 4);
fillFunc(AZ::RHI::ShadingRate::Rate2x1, 3, gridSize - 1, 2, 1);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 3, gridSize - 1, 1, 1);
}
break;
case AZ::RHI::XRFoveatedLevel::High:
{
// 1 2 3 4 5 6 7 8
// _______________________________________________
// |______________________4x4 _____________________| 1
// | | | | | | | | 2
// | | | | | | | | 3
// | 4x4 | 4x2 | 2x2 | | 2x2 | 4x2 | 4x4 | 4
// | | | | 1x1 | | | | 5
// | | | | | | | | 6
// |_____|_____|_____|___________|_____|_____|_____| 7
// |______________________4x4______________________| 8
fillFunc(AZ::RHI::ShadingRate::Rate4x4, 0, 0, 4, 1);
fillFunc(AZ::RHI::ShadingRate::Rate4x4, 0, 1, 1, 6);
fillFunc(AZ::RHI::ShadingRate::Rate4x4, 0, gridSize - 1, 4, 1);
fillFunc(AZ::RHI::ShadingRate::Rate4x2, 1, 1, 1, 6);
fillFunc(AZ::RHI::ShadingRate::Rate2x2, 2, 1, 1, 6);
}
break;
case AZ::RHI::XRFoveatedLevel::None:
Expand Down
4 changes: 2 additions & 2 deletions Projects/OpenXRTest/Registry/OpenXR.setreg
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"Atom": {
"OpenXR": {
"Enable": true,
"android_ViewResolutionScale": 0.75,
"FoveatedLevel": 0
"android_ViewResolutionScale": 1.0,
"FoveatedLevel": 3
}
}
}
Expand Down

0 comments on commit 506397b

Please sign in to comment.