Upgraded openxr dependency to 1.1.41. #823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galibzon
requested review from
nick-l-o3de,
moudgils,
spham-amzn,
antonmic and
amzn-changml
antonmic
approved these changes
Feb 3, 2025
moudgils
approved these changes
Feb 3, 2025
byrcolin
added
sig/graphics-audio
|
Promotion job here: https://github.com/o3de/3p-package-source/actions/runs/13694233719. Will push to prod once this passes AR. Please hold off on merging until the promotion is complete |
amzn-changml
requested changes
Mar 6, 2025
Gems/OpenXRVk/3rdParty/Platform/Android/BuiltInPackages_android.cmake
Outdated
Show resolved
Hide resolved
Gems/OpenXRVk/3rdParty/Platform/Windows/BuiltInPackages_windows.cmake
Outdated
Show resolved
Hide resolved
This update makes it straightforward to build O3DE applications for Meta Quest devices, because the developer is not required anymore to download and decompress the `Oculus OpenXR Mobile SDK`. To understand this change, let's review a little bit of history: When making O3DE apps for Meta Quest devices, the developer was instructed to manually download and decompress the `Oculus OpenXR Mobile SDK` into a particular directory of the `OpenXRVk` Gem. Those instructions worked well until SDK v62. Starting SDK v63+ (It's currently at v72) Meta stopped distributing pre-compiled OpenXR Loader libraries, and now applications are simply required to get the OpenXR Loader directly from github: https://github.com/KhronosGroup/OpenXR-SDK In particular, this PR picks version 1.1.41 because that's the version used by `v72` of `Oculus OpenXR Mobile SDK`. In other words, with this change, OpenXR is now supported in its purest form, because there are no custom steps for a particular vendor. Updated to rev2 of openxr-1.1.41 package which was recompiled by the 3p-package-source with NDK 25. Signed-off-by: galibzon <[email protected]>
galibzon
force-pushed
the
galibzon/OpenXR.1.1.41
branch
from
787b7cd to
6d1938c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades openxr dependency to 1.1.41, and simplifies developer steps to build O3DE apps on Meta Quest devices.
This update makes it straightforward to build O3DE applications for Meta Quest devices, because the developer is not required anymore to download and decompress the
Oculus OpenXR Mobile SDK.To understand this change, let's review a little bit of history: When making O3DE apps for Meta Quest devices, the developer was instructed to manually download and decompress the
Oculus OpenXR Mobile SDKinto a particular directory of theOpenXRVkGem.Those instructions worked well until SDK v62.
Starting SDK v63+ (It's currently at v72)
Meta stopped distributing pre-compiled OpenXR Loader libraries, and now applications are simply required to get the OpenXR Loader directly from github: https://github.com/KhronosGroup/OpenXR-SDK
In particular, this PR picks version 1.1.41 because that's the version used by
v72ofOculus OpenXR Mobile SDK.In other words, with this change, OpenXR is now supported in its purest form, because there are no custom steps for a particular vendor.
How was this PR tested?
OpenXRTestproject withXR_Officelevel on both Windows (Using Quest Link with a Quest3 device) and natively on Android running on a Quest3.REMARK 1: This PR is contingent on
https://github.com/o3de/3p-package-source/pull/270.REMARK 2: Not validated on Linux (and not sure if OpenXR support has ever been tested on Linux).
REMARK 3: Updated to rev2 of openxr-1.1.41 package which was recompiled by the 3p-package-source with NDK 25.