-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: Use oVirt Tiny Core instead of cirros #162
Open
lveyde
wants to merge
25
commits into
oVirt:tinycore-test
Choose a base branch
from
lveyde:tinycore-test
base: tinycore-test
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lveyde
force-pushed
the
tinycore-test
branch
7 times, most recently
from
May 24, 2022 22:39
7b72d2c
to
4695c5d
Compare
To maintain uniformity across all suites using storage VMs, add storage network and NICs.
workaround for BZ2084118, downgrading nmstate at el9 hosts. [1] https://bugzilla.redhat.com/show_bug.cgi?id=2084118
el9 doesn't support QXL devices, this patch modifies the tests to use non-QXL devices on el9.
This reverts commit 67405b5.
We no longer use stdci jobs, so we don't need the code for finding RPM repositories in jenkins links. Signed-off-by: Marcin Sobczyk <[email protected]>
After the change in the Grafana UI we are no longer able to detect error messages displayed. This patch updates the checks for errors in Grafana and also makes sure that the test fails if the notifications list element is not detected - that could mean that the UI changed and we are not able to detect errors again.
On el9stream hosts we configure libvirt to use the monolithic daemon during host deployment [1]. Until now we used to reboot only one of the hosts in a basic suite run to make it faster, but that libvirt change requires all hosts to be rebooted. [1] oVirt/ovirt-engine#80 Signed-off-by: Marcin Sobczyk <[email protected]>
it needs to match the actual job parameters
There is no `async_` argument for the `add()` call in `ExternalVmImportService`. The argument is silently ignored and having that in the call is misleading/confusing to anyone reading the code. Signed-off-by: Tomáš Golembiovský <[email protected]>
* add convert disk test Convert small raw disk to qcow with incremental backup enabled Signed-off-by: Benny Zlotnik <[email protected]>
Change-Id: I20678e6eb9dfa30e09711f305ebf3b92b11f7302 Signed-off-by: Eitan Raviv <[email protected]>
Change-Id: I680a523e71bc6e413b807de8f1ec3782253bb261 Signed-off-by: Eitan Raviv <[email protected]>
Align with PR#135 [1]: By default 'Popen' processes's stdout is opened as a byte stream. Passing the 'universal_newlines=True' argument makes the stream automatically decoded from UTF-8. Since we're reading the output char by char, multibyte UTF-8 characters can break the stream with i.e.: E UnicodeDecodeError: 'utf-8' codec can't decode byte 0xda ... invalid continuation byte Let's change the output to have a form of bytes and use bytes in comparisons too. [1] oVirt#135 Change-Id: I799faaa6617b7a1f48ce9175509eef1d7e62c4de Signed-off-by: Eitan Raviv <[email protected]> Change-Id: Ic550276233f6e1908c67d4c8a3cd9d7a05a5cd4a Signed-off-by: Eitan Raviv <[email protected]>
Change-Id: I91a68aa19c489b7540befdc74894b518c63fc55c Signed-off-by: Eitan Raviv <[email protected]> Change-Id: Ia59c99da78d2ab0b32edfac456760b079c3281e3
An initial wait before pre_login has proved mandatory for the success of the connection with the guest: sending characters down the pipe too early causes the connection to block indefinitely. Short waits between reads are suspect of making the pipe flaky and prone to sometimes block indefinitely. Change-Id: I70ded06929a65ce2a89eace3a34d30c3f0b43063 Signed-off-by: Eitan Raviv <[email protected]>
Signed-off-by: Aviv Litman <[email protected]>
When keycloak is enabled to web-UI username is admin@ovirt, instead of admin. Signed-off-by: Aviv Litman <[email protected]>
Downgrade OVN to 21.12.0-46 on the engine machine so it matches the latest available version for RHVH. Change-Id: I6bc99e9d5aa0beb19a70d8f124407e0f7c7fffe4 Bug-Url: https://bugzilla.redhat.com/2091565 Signed-off-by: Eitan Raviv <[email protected]>
* setup_engine: Ignore errors on downgrade Signed-off-by: Marcin Sobczyk <[email protected]> Co-authored-by: michalskrivanek <[email protected]>
When a VM misbehaves, e.g. very slow to respond, it sometimes sends non-decodable bytes on the vmconsole connection stream. These bytes can be ignored while waiting for the expected response. Change-Id: Id4027103d609f42642e744387c80b3dccbd0ca43 Signed-off-by: Eitan Raviv <[email protected]>
Signed-off-by: Marcin Sobczyk <[email protected]> Signed-off-by: Lev Veyde <[email protected]>
sandrobonazzola
requested review from
michalskrivanek,
ljelinkova and
erav
and removed request for
michalskrivanek
July 6, 2022 08:06
@lveyde can you please resolve conflicts here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcin Sobczyk [email protected]
Signed-off-by: Lev Veyde [email protected]