-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy automation #308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesteve-rh
requested review from
nirs,
mz-pdm,
almusil and
tinez
as code owners
September 5, 2022 08:38
nirs
requested changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why rename tons of files in automation/ and delete them in the next commit? It would be better to delete the unused file first, then rename the few used files.
nirs
reviewed
Sep 5, 2022
aesteve-rh
force-pushed
the
aesteve/remove_automation
branch
from
September 5, 2022 14:54
a4afcdf
to
c7faa5f
Compare
mz-pdm
previously approved these changes
Sep 7, 2022
nirs
previously approved these changes
Sep 7, 2022
nirs
force-pushed
the
aesteve/remove_automation
branch
from
September 7, 2022 13:51
c7faa5f
to
ee41205
Compare
Signed-off-by: Albert Esteve <[email protected]>
Remove all unused scripts from the automation folder. Related: oVirt#43 Signed-off-by: Albert Esteve <[email protected]>
Rename automation folder to ci and update all references to automation scripts. Related: oVirt#43 Signed-off-by: Albert Esteve <[email protected]>
Add a script to install packages that were obtained in the ci/check-path.packages list. Update development.md to use the new script to install additional dependencies. Fixes: oVirt#43 Signed-off-by: Albert Esteve <[email protected]>
aesteve-rh
force-pushed
the
aesteve/remove_automation
branch
from
September 7, 2022 13:51
ee41205
to
13028b5
Compare
nirs
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename automation folder to ci and update all
references to automation scripts.
Remove unused ci (old automation) scripts.
Fixes: #43
Signed-off-by: Albert Esteve [email protected]