Skip to content

Commit

Permalink
[ObjC] Remove unused internal method.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 509946709
  • Loading branch information
protobuf-github-bot authored and copybara-github committed Feb 15, 2023
1 parent 8d8527b commit 1a90e67
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
7 changes: 0 additions & 7 deletions objectivec/GPBUnknownFieldSet.m
Original file line number Diff line number Diff line change
Expand Up @@ -289,13 +289,6 @@ - (void)mergeUnknownFields:(GPBUnknownFieldSet *)other {
}
}

- (void)mergeFromData:(NSData *)data {
GPBCodedInputStream *input = [[GPBCodedInputStream alloc] initWithData:data];
[self mergeFromCodedInputStream:input];
[input checkLastTagWas:0];
[input release];
}

- (void)mergeVarintField:(int32_t)number value:(int32_t)value {
checkNumber(number);
[[self mutableFieldForNumber:number create:YES] addVarint:value];
Expand Down
1 change: 0 additions & 1 deletion objectivec/GPBUnknownFieldSet_PackagePrivate.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
- (void)mergeUnknownFields:(GPBUnknownFieldSet *)other;

- (void)mergeFromCodedInputStream:(GPBCodedInputStream *)input;
- (void)mergeFromData:(NSData *)data;

- (void)mergeVarintField:(int32_t)number value:(int32_t)value;
- (BOOL)mergeFieldFrom:(int32_t)tag input:(GPBCodedInputStream *)input;
Expand Down
3 changes: 2 additions & 1 deletion objectivec/Tests/GPBUnknownFieldSetTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,8 @@ - (void)testLargeVarint {
NSData* data = [fields data];

GPBUnknownFieldSet* parsed = [[[GPBUnknownFieldSet alloc] init] autorelease];
[parsed mergeFromData:data];
GPBCodedInputStream* input = [[[GPBCodedInputStream alloc] initWithData:data] autorelease];
[parsed mergeFromCodedInputStream:input];
GPBUnknownField* field2 = [parsed getField:1];
XCTAssertEqual(field2.varintList.count, (NSUInteger)1);
XCTAssertEqual(0x7FFFFFFFFFFFFFFFULL, [field2.varintList valueAtIndex:0]);
Expand Down

0 comments on commit 1a90e67

Please sign in to comment.