This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
added data into SocketLoggerServer trace logs #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nofateg
reviewed
Jan 9, 2024
Comment on lines
+128
to
+130
| log.trace( "[{}] logging (properties {} filePreffix {} logType {} headers {} types {} data {} length {})", | ||
| hostName, properties, filePreffix, logType, headers, types, | ||
| "|" + new String( buffer, StandardCharsets.UTF_8 ).replace( "\n", "|" ), length ); |
There was a problem hiding this comment.
What would the binary data look like in such a trace?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to see data that has been logged into the files
format: 1
7:34:23.160 [XNIO-2 task-2] TRACE o.logstream.net.SocketLoggerServer - [localhost] logging (properties {NAME=event} filePreffix /${NAME} logType event1 headers [TIMESTAMP NAME VALUE1 VALUE2 VALUE3] types [[1]] data |2021-01-01 01:00:00 event value1 222 333|2021-01-01 01:00:00 event value1 222 333| length 82)
@nofateg please review