Analyse with puppeteer #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfhandl
reviewed
Dec 4, 2023
Comment on lines
+99
to
+102
| - [`npm run select <CSS selector> [<XPath expression>]`](selector.mjs) selects parts of the generated HTML documents by executing a CSS selector and optionally an XPath expression relative to each match. For example, syntax errors in JSON code snippets can be detected with | ||
| ```sh | ||
| npm run select ".json .er" "self::*[.!='…']/text()" | ||
| ``` |
There was a problem hiding this comment.
Why not have a postbuild script that calls this validation?
There was a problem hiding this comment.
Perhaps later if we find a better XPath expression. For now the result still contains too many false positives.
ralfhandl
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tool that helps with the analysis of the generated HTML documents. For example, syntax errors in code snippets can be detected with
The first argument is a CSS selector, the (optional) second is an XPath expression.