All NavigationPropertyRestrictions nullable
#286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfhandl
reviewed
Jan 10, 2025
| @@ -272,16 +272,16 @@ supported: | |||
| <Property Name="SortRestrictions" Type="Capabilities.SortRestrictionsType"> | |||
| <Annotation Term="Core.Description" String="Restrictions on orderby expressions" /> | |||
| </Property> | |||
| <Property Name="TopSupported" Type="Edm.Boolean" Nullable="false" DefaultValue="true"> | |||
| <Property Name="TopSupported" Type="Edm.Boolean"> | |||
There was a problem hiding this comment.
Suggested change
| <Property Name="TopSupported" Type="Edm.Boolean"> | |
| <Property Name="TopSupported" Type="Edm.Boolean" Nullable="true"> |
Better state explicitly that we mean it and didn't just forget it.
And maybe describe what null/omission means.
There was a problem hiding this comment.
Better state explicitly that we mean it and didn't just forget it.
Only for these two, or also for all others?
And maybe describe what null/omission means.
Isn't that already said?
There was a problem hiding this comment.
All four that were touched in this PR, please
ralfhandl
approved these changes
Jan 15, 2025
|
TC 2025-01-22 decided against this incompatible change. |
HeikoTheissen
added a commit
to oasis-tcs/odata-openapi
that referenced
this pull request
Jan 23, 2025
HeikoTheissen
added a commit
to oasis-tcs/odata-openapi
that referenced
this pull request
Jan 23, 2025
This reverts commit 910d724.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes oasis-tcs/odata-openapi#322