-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix sapphire-localnet startup on Mac Docker #593
Conversation
Closes #592 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does something related to version determination fail? What is the "version line" output on the failing machine?
Thanks, but can you also show the exact output of the "version line" after you run the Docker image with the proposed workaround from this PR. |
There was no version line, it failed beforehand. |
As mentioned in the comment, what is the output with the proposed fix from this PR. |
e1e29a2
to
7b62c9a
Compare
7b62c9a
to
ea76d83
Compare
Here is the output(Docker image build by @abukosek, and tested on my machine): |
Here is what I think was the problem and why just moving The initial problem was that when running the image on Docker Mac on a machine with Apple M silicon (with the appropriate We narrowed this down to the following line in the script:
Sometimes it looked like However, on Apple M silicon, Docker images run in an emulation layer and run more slowly. Normally, this wouldn't be a problem, but in this case, the output from This also explains why the error was so random -- sometimes the process managed to output everything on time and exited cleanly, but sometimes it was interrupted by the broken pipe and brought down the entire script with it. So, moving the |
This PR fixes
sapphire-localnet
startup in Docker on Mac, as reported by @lubej.