Feature/AUT-3790/resource manager deletion hook #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version
There are 0 BREAKING CHANGE, 2 features, 0 fix |
Coverage Report
|
This was referenced Aug 27, 2024
jsconan
requested review from
shaveko,
Karol-Stelmaczonek and
viktar-dzmitryieu-tao
viktar-dzmitryieu-tao
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
viktar-dzmitryieu-tao
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
gabrielfs7
reviewed
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/AUT-3790
Summary
Allow to hook the file deletion in the resource manager.
Details
The file deletion in the resource manager was relying on the
ui/deleterhelper, which is a global helper watching for elements having thedata-deleteattribute and adding behavior to them. However, it was impossible to hook it and insert a validation step in the middle. While this is possible to inject a step between the deletion event and the file deletion, the deletion event is emitted after the line is removed from the DOM. For this is reason, it is better to break the dependency to theui/deleterhelper and write a specific handling directly to the fileSelector component, adding an option to hook it.How to test
Please refer to the companion PR.