bug(#3708): tests for UnphiMojo cache #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon check please. Fixed tests to fit new logic with footprint. |
maxonfjvipon
requested changes
Jan 6, 2025
eo-maven-plugin/src/test/java/org/eolang/maven/UnphiMojoCacheTest.java
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/test/java/org/eolang/maven/UnphiMojoCacheTest.java
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/test/java/org/eolang/maven/UnphiMojoCacheTest.java
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/test/java/org/eolang/maven/UnphiMojoCacheTest.java
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/test/java/org/eolang/maven/UnphiMojoCacheTest.java
Outdated
Show resolved
Hide resolved
…/tests-xmir-to-phi
|
@maxonfjvipon Hi! Thx for the detailed comments. Fixed, check it out when possible. |
maxonfjvipon
requested changes
Jan 9, 2025
There was a problem hiding this comment.
@ArtemGet almost good, just a several comments to be resolved and we're good to merge
eo-maven-plugin/src/test/java/org/eolang/maven/UnphiMojoTest.java
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/test/java/org/eolang/maven/UnphiMojoTest.java
Outdated
Show resolved
Hide resolved
|
@maxonfjvipon Fixed, would you check it out, please? |
|
@yegor256 please check |
yegor256
reviewed
Jan 10, 2025
|
@ArtemGet looks very good, thanks! One small comment above. |
|
@yegor256 Removed unused constant. It would be added with next PR. |
…/tests-xmir-to-phi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3708