docs command added #413
Merged
docs command added #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yegor256 Can you take a look, please? |
|
@SenjeyB please, make sure all CI jobs pass before manual review |
yegor256
reviewed
Dec 10, 2024
src/commands/docs.js
Outdated
| * @param {Hash} opts - All options | ||
| */ | ||
| module.exports = function(opts) { | ||
| console.info('Hello World!'); |
There was a problem hiding this comment.
@SenjeyB maybe it's better to print something like "This command is not yet implemented, sorry"
|
@SenjeyB looks good now, but how about a test? Adding new code not covered by tests is a bad idea in general. |
|
@rultor merge |
|
@SenjeyB thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added docs command, which does should print 'Hello World'.