Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#999): Add PHI/UNPHI Steps to jna Integration Test #1003

Merged
merged 7 commits into from
Feb 17, 2025

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Feb 13, 2025

In this PR I switch jna integration test from the short profile to the full profile.
By doing this, we enable PHI/UNPHI transformations in the test. It slightly slows down the integration test, but ensures qality.

Also, I slightly refactored benchmark.groovy script to switch between integration tests faster.

Closes: #999.

@volodya-lombrozo volodya-lombrozo marked this pull request as ready for review February 17, 2025 08:25
@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you review these changes, please?

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo looks good!

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Feb 17, 2025

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 39300f3 into objectionary:master Feb 17, 2025
12 checks passed
@rultor
Copy link
Contributor

rultor commented Feb 17, 2025

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 6min).

@0crat
Copy link

0crat commented Feb 17, 2025

@yegor256 Thank you for your code review contribution! We appreciate your effort, but there's room for improvement. According to our policy, you've earned 4 base points, but we've had to deduct 10 points due to the low number of comments (only 4). To ensure you receive some recognition, we've added 10 points, resulting in a total of +4 points for this review. Your current balance stands at -210. We encourage you to provide more detailed feedback in future reviews to maximize your rewards. Keep up the good work! 💻👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invoker.properties:24-31: Use 'full' profile for...
5 participants