-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(#209): XMIR links in Program
, Programs
, Defect
JavaDoc
#229
Conversation
@volodya-lombrozo please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel Thank you for the contribution! Links are really helpful for developers of objectionary/lints
. However, I should be honest with you: for users of objectionary/lints
these links are useless.
Let's imagine a user that sees the following error:
[mandatory-home WARNING]:0 The +home meta is mandatory, but is absent
In this case, the user will rise one more issue in this repository or disable the linter completely. Checking code in this repository is the last thing user will do.
We need to show the error message together with the link to the documentation, otherwise it won't work.
@volodya-lombrozo how about this: #214 (comment)? |
@h1alexbel I don't like the idea of "searching" something. I would like to see the link for each linter in a row:
But what you have suggested is already much better than what we have now. |
@volodya-lombrozo @h1alexbel we have two types of users:
The first type of users will use eo-maven-plugin (or eoc) and will see the output in text form in command line. They will see the links to "motive" pages. Now they don't, but here is the ticket for this: objectionary/eo#3800 The second type of users will use |
@yegor256 @volodya-lombrozo for the second group, for the "users of API", I created this PR. I suggest to merge it, if its good enough. For the first group we will implement objectionary/eo#3800. But, as far I understand, JEO uses only lints API, so @volodya-lombrozo won't get any motives on his side, the motives only will come from |
@h1alexbel yes, users of API (@volodya-lombrozo is one of them) only get a list of |
* source code and points to the problem in it. Some defects report the problems | ||
* on XMIR format itself, consider to check resources on XMIR in order to get | ||
* understanding how intermediate representation of EO is structured in XML format. | ||
* @see <a href="https://news.eolang.org/2022-11-25-xmir-guide.html">XMIR guide</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel read this: https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html
also, run mvn site -Psite
and then open the files generated in target/site/javadoc/index.html
You will see how your text is formatted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yegor256 getting this:
should be good I believe, or I missing something?
@h1alexbel thanks! |
In this pull I've updated JavaDocs of
Program.java
,Programs.java
,Defect.java
, now they mention XMIR, and resources about it.see #209