Add definitions to terms for neurons that lack them #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouttegd
requested changes
Feb 21, 2025
| @@ -4668,13 +4667,6 @@ AnnotationAssertion(oboInOwl:hasDbXref obo:CL_0000108 "WBbt:0006840") | |||
| AnnotationAssertion(rdfs:label obo:CL_0000108 "cholinergic neuron") | |||
| EquivalentClasses(obo:CL_0000108 ObjectIntersectionOf(obo:CL_0000540 ObjectSomeValuesFrom(obo:RO_0002215 obo:GO_0014055))) | |||
|
|
|||
| # Class: obo:CL_0000109 (adrenergic neuron) | |||
There was a problem hiding this comment.
Is that term removed because it “should be a synonym of noradrenergic neuron” (as stated in this comment)?
Terms should never be entirely removed like that. They should be obsoleted instead – kept around, but clearly marked as obsolete with a owl:deprecated annotation.
| @@ -4554,5 +4552,5 @@ | |||
|
|
|||
|
|
|||
|
|
|||
| <!-- Generated by the OWL API (version 4.5.29) https://github.com/owlcs/owlapi --> | |||
| <!-- Generated by the OWL API (version 4.5.26.2023-07-17T20:34:13Z) https://github.com/owlcs/owlapi --> | |||
There was a problem hiding this comment.
Has this file been modified with Protégé?
This file is automatically generated from the mappings between CL and foreign ontologies. It should not be manually edited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2342