Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(security): Set "allowPrivilegeEscalation: false" in Prometheus container #103

Merged
merged 2 commits into from
Mar 25, 2024
Merged

feat(security): Set "allowPrivilegeEscalation: false" in Prometheus container #103

merged 2 commits into from
Mar 25, 2024

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Mar 25, 2024 •
edited
Loading

Description of Changes

We should be setting allowPrivilegeEscalation to false. Prometheus does not require a privileged user or the ability to escalate its privileges.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

@jsirianni jsirianni marked this pull request as ready for review March 25, 2024 22:38
@jsirianni jsirianni requested a review from a team as a code owner March 25, 2024 22:38
@jsirianni jsirianni requested review from shazlehu and Mrod1598 March 25, 2024 22:38
@jsirianni jsirianni merged commit 3d7a4ec into main Mar 25, 2024
13 checks passed
@jsirianni jsirianni deleted the prometheus-security-enhancements branch March 25, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andykellr andykellr andykellr approved these changes

@shazlehu shazlehu Awaiting requested review from shazlehu shazlehu was automatically assigned from observIQ/platform

@Mrod1598 Mrod1598 Awaiting requested review from Mrod1598 Mrod1598 was automatically assigned from observIQ/platform

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirianni @andykellr