fix: Skip mounting Postgres TLS certificats from secret when sslSource is 'manual' #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbm48813
approved these changes
Dec 12, 2024
Base automatically changed from
joesirianni/bpop-1278-helm-allow-setting-terminationgraceperiodsecondsfor-all
to
main
December 12, 2024 21:13
jsirianni
force-pushed
the
joesirianni/bpop-1279-helm-allow-postgres-tls-configuration-to-use-volume-mount.2
branch
from
3ca4a6a to
727466b
Compare
jsirianni
deleted the
joesirianni/bpop-1279-helm-allow-postgres-tls-configuration-to-use-volume-mount.2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When Postgres sslSource is not "source", the config map for initializing the Postgres TLS emptydir volume should still be used, but it should skip copying the files from the secret to the emptyDir.
Please check that the PR fulfills these requirements