epic(prometheus): Always use Prometheus #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirianni
changed the title
jsirianni
force-pushed
the
epic/always-on-prometheus
branch
from
e8c0a7c to
a1f3583
Compare
jsirianni
force-pushed
the
epic/always-on-prometheus
branch
from
4c2d516 to
cf61465
Compare
* use bindplane prometheus image and remove configmap * remove args, they are set in the container image already. updaste volume mount to use /prometheus, the correct path for the bindplane-prometheus image * pin sidecar test version
jsirianni
force-pushed
the
epic/always-on-prometheus
branch
from
b78b381 to
d1ca4f9
Compare
* remove sidecar * rename dev prometheus config * add prometheus statefulset * true up securityContext * add remote option * regen docs * remove prom enable from templates * use generated service name when host is not set * fix svc name * re-add sideCar option * revert size change * use localhost when sidecar * Regen docs * resolve test issues by using newer image * use ee image * Remove all test case as it requires a license * skip if dev prometheus is enabled * fix condition * add fsgroup for gke
jsirianni
requested review from
BinaryFissionGames,
shazlehu and
dpaasman00
and removed request for
shazlehu
dpaasman00
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This branch is an epic branch for the "Always Use Prometheus" effort. It is safe to merge
It contains the following commits:
It contains the following approved pull requests:
NOTE: I went back and built
bindplane-prometheusimages for every release (v1.37.0 through current) to make sure anyone on older bindplane versions can still leverage the latest Prometheus options and expectations in this chart.Release Notes (will be included in this repos release, and bindplane's release notes)
As of Chart version
1.2.0, Prometheus will be used as BindPlane's measurement backend. Prometheus is used to store historical throughput data gathered from your managed agents.Upgrade Procedure
Prometheus Not Previously Configured
If you do not have Prometheus configuration in your values file, no action is needed. Once upgraded, you will see
a new Prometheus StatefulSet in your BindPlane namespace.
Prometheus Side Car Configured
If you have
prometheus.enableSideCarset, no action is needed. You can removeprometheus.enableas this option has been removed.Self Managed Prometheus
If you have
prometheus.hostset, pointing to a self managed Prometheus instance, you must setprometheus.remote: truein your values file. You can removeprometheus.enableas this option has been removed.Please check that the PR fulfills these requirements