-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
annotate local paths #1731
Open
Fil
wants to merge
14
commits into
main
Choose a base branch
from
fil/annotate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
annotate local paths #1731
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6cfb74d
annotate local paths (_import and _file)
Fil 06b5fee
test
Fil 5b7ad8d
transpile
Fil 1136735
more transpile
Fil 4224b3a
transpiled modules only
Fil d706f6c
dynamicPath annotate.js
Fil 498d37b
this part is about pages, do not annotate
Fil b69ad62
flatten file attachments json
Fil aec5051
isPathImport
Fil 829e087
tests
Fil fabeb4f
remove early test
Fil 963aeb8
Merge branch 'main' into fil/annotate
Fil 7c96c68
fix tests
Fil e0bc373
Annotate scripts in _node, _npm, and _jsr
Fil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import {FileAttachment} from "observablehq:stdlib"; | ||
|
||
// Framework’s FileAttachment | ||
FileAttachment("./lib/miserables.json").json(); | ||
|
||
// Static ESM imports | ||
import {foo, bar} from "./foo.js"; | ||
|
||
import {Chart} from "./chart.js"; | ||
|
||
// Dynamic ESM imports | ||
const {Chart: c} = await import("./chart.js"); | ||
|
||
// import.meta.resolve | ||
const chartHelperURL = import.meta.resolve("./chart.js"); | ||
|
||
console.warn({foo, bar, Chart, c, chartHelperURL}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
isAssetPath
or whatever that’s['./', '../', '/']
. Don’t want to match against.foo
.