add made by observable component #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
approved these changes
Oct 11, 2024
mbostock
reviewed
Oct 12, 2024
| @@ -296,7 +296,6 @@ body { | |||
| position: fixed; | |||
| color: var(--theme-foreground-muted); | |||
| font: 400 14px var(--sans-serif); | |||
| z-index: 1; | |||
There was a problem hiding this comment.
The TOC links are currently not clickable without the z-index: 1 because they are obscured (invisibly) by the main column. We’ll need to fix this ASAP, perhaps by putting the observable-made-by within its own z-index container. Edit: Fixed in fa2b5b6.
mbostock
added a commit
that referenced
this pull request
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Made by Observable button to the header of the site.
logo()function in the config file since the code was duplicated