Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle absolute global imports #1758

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Oct 14, 2024

Fixes #1755. I’d like a test here, but I think it would require us to mock out the contents of jsDelivr responses. I tested manually using the repro in the linked issue. Added an automated test, easy enough.

@mbostock mbostock requested a review from Fil October 14, 2024 18:41
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbostock mbostock enabled auto-merge (squash) October 14, 2024 19:00
@mbostock mbostock merged commit 05707b3 into main Oct 14, 2024
4 checks passed
@mbostock mbostock deleted the mbostock/handle-absolute-global-imports branch October 14, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

absolute URL imports aren’t correctly resolved during build
2 participants