Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note loaders #1776

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

note loaders #1776

wants to merge 3 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Oct 22, 2024

  • get source & params for pages
  • get source & params for modules
  • get source & params for files (copied and generated)
  • write the build manifest
  • fix types in deploy
  • test deploy
  • fix deploys (currently it errors 400)
  • add unit test for all 4 cases
  • add unit test for deploys

Comment on lines -93 to +84
const source = await readFile(join(this.root, await loader.load(options, effects)), "utf8");
return parseMarkdown(source, {params: loader.params, ...options});
const input = await readFile(join(this.root, await loader.load(options, effects)), "utf8");
return parseMarkdown(input, {source: loader.path, params: loader.params, ...options});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: this change of variables names is wrong, like it is below in parseMarkdown. The issue is that there are too many things that we want to call "path".

@Fil Fil requested a review from mythmon October 23, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant