Fix bug where SqlDeconstructMaybe instance would consider a record to…

… be Nothing if any one of its fields was Nothing.
obsidiansystems · Jan 10, 2023 · 325fa1c · 325fa1c
1 parent f537ac5
commit 325fa1c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/beam-core/Database/Beam/Query/Combinators.hs b/beam-core/Database/Beam/Query/Combinators.hs
@@ -845,7 +845,7 @@ instance BeamSqlBackend be => SqlDeconstructMaybe be (QGenExpr ctxt be s (Maybe
 
 instance ( BeamSqlBackend be, Beamable t)
     => SqlDeconstructMaybe be (t (Nullable (QGenExpr ctxt be s))) (t (QGenExpr ctxt be s)) s where
-    isJust_ t = allE (allBeamValues (\(Columnar' e) -> isJust_ e) t)
+    isJust_ t = not_ (isNothing_ t)
     isNothing_ t = allE (allBeamValues (\(Columnar' e) -> isNothing_ e) t)
     maybe_ (QExpr onNothing) onJust tbl =
       let QExpr onJust' = onJust (changeBeamRep (\(Columnar' (QExpr e)) -> Columnar' (QExpr e)) tbl)