Use GADT to avoid closures #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polytypic
force-pushed
the
use-gadt-to-avoid-closures
branch
from
0a60511
to
8ba27bb
Compare
polytypic
force-pushed
the
use-gadt-to-avoid-closures
branch
3 times, most recently
from
a35efe3
to
4a7d8a6
Compare
polytypic
force-pushed
the
use-gadt-to-avoid-closures
branch
5 times, most recently
from
d320536
to
0f7a159
Compare
polytypic
force-pushed
the
use-gadt-to-avoid-closures
branch
15 times, most recently
from
5cfa392
to
008daba
Compare
polytypic
force-pushed
the
use-gadt-to-avoid-closures
branch
from
008daba
to
8ae5409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the internal update operation to use a GADT to indicate which kind of operation to perform. This helps to avoid allocations for certain operations. The inline attribute is also removed from the internal update function. This reduces code size significantly. The periodic validation is also restricted to happen only on accesses of locations that have been accessed previously.