Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just saw another occurrence failing to trigger a parallel STM Weak HashSet failure, this time under 5.1 bytecode:
https://github.com/ocaml-multicore/multicoretests/actions/runs/5488638494/jobs/10001760309
I therefore ran a bit of failure rate stats only to learn that the error rate is pretty slim under both native and bytecode:
This PR therefore raises the count from 2000 to 5000.
$( 1 - 1/2000 ) ^{count}$ .
This decreases the chance of completing a non-error-triggering run from 37% to 0.8% if my calculations are right