Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak hashset adjustment #372

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Weak hashset adjustment #372

merged 2 commits into from
Jul 11, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jul 10, 2023

I just saw another occurrence failing to trigger a parallel STM Weak HashSet failure, this time under 5.1 bytecode:
https://github.com/ocaml-multicore/multicoretests/actions/runs/5488638494/jobs/10001760309

random seed: 192914563
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 1000     0.0s STM Weak HashSet test sequential
[ ]    0    0    0    0 / 1000     0.0s STM Weak HashSet test sequential (generating)
[✓] 1000    0    0 1000 / 1000     2.7s STM Weak HashSet test sequential
================================================================================
success (ran 1 tests)
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 2000     0.0s STM Weak HashSet test parallel
[ ]  742    0    0  742 / 2000    57.3s STM Weak HashSet test parallel
[ ] 1497    0    0 1497 / 2000   117.6s STM Weak HashSet test parallel
[✗] 2000    0    0 2000 / 2000   160.6s STM Weak HashSet test parallel

I therefore ran a bit of failure rate stats only to learn that the error rate is pretty slim under both native and bytecode:

jmi@MintPad:~/software/multicoretests-latest$ dune exec src/weak/stm_tests_hashset_stats.exe -- -v
Weak Hashset 5 / 10000              
jmi@MintPad:~/software/multicoretests-latest$ dune exec src/weak/stm_tests_hashset_stats.bc -- -v
Weak Hashset 5 / 10000              

This PR therefore raises the count from 2000 to 5000.
This decreases the chance of completing a non-error-triggering run from 37% to 0.8% if my calculations are right
$( 1 - 1/2000 ) ^{count}$.

@jmid
Copy link
Collaborator Author

jmid commented Jul 11, 2023

CI summary

None of these are related to the adjusted Weak hashset test, so I'll merge

@jmid jmid merged commit de0d268 into main Jul 11, 2023
@jmid jmid deleted the weak-hashset-adjustment branch July 11, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant