Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pcsig_self optionnal #2216

Merged
merged 6 commits into from
Jan 4, 2023
Merged

Conversation

EmileTrotignon
Copy link
Collaborator

Please do not merge, this for visualizing a diff.

vendor/parser-extended/parsetree.mli Outdated Show resolved Hide resolved
vendor/parser-extended/ast_mapper.ml Outdated Show resolved Hide resolved
lib/Fmt_ast.ml Outdated Show resolved Hide resolved
@gpetiot gpetiot mentioned this pull request Dec 14, 2022
18 tasks
@gpetiot gpetiot marked this pull request as ready for review December 28, 2022 17:08
Copy link
Collaborator

@gpetiot gpetiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gpetiot gpetiot added the no changelog set this to bypass the CI check for changelog entries label Dec 28, 2022
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@gpetiot gpetiot merged commit aeb9965 into ocaml-ppx:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog set this to bypass the CI check for changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants