Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pkg): apply @talex5 optimization #11294

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

rgrinberg
Copy link
Member

Documented in https://roscidus.com/blog/blog/2024/07/22/performance-2/

Signed-off-by: Rudi Grinberg <[email protected]>

<!-- ps-id: c607e4a6-19fa-4c26-bcdd-f356317868cd -->

Signed-off-by: Rudi Grinberg <[email protected]>
@rgrinberg
Copy link
Member Author

This PR is part of a series optimizations started by @gridbugs. This particular optimization isn't all that relevant, but it's a good baseline from the "known" set of improvements.

@rgrinberg
Copy link
Member Author

rgrinberg commented Jan 14, 2025

Here's a benchmark for posterity:

PR:
Benchmark 1: ~/github/ocaml/dune/_build/install/default/bin/dune pkg lock
  Time (mean ± σ):      2.869 s ±  0.195 s    [User: 1.935 s, System: 0.676s]
  Range (min … max):    2.710 s …  3.325 s    10 runs

main:
Benchmark 1: ~/github/ocaml/dune/_build/install/default/bin/dune pkg lock
  Time (mean ± σ):      2.974 s ±  0.181 s    [User: 1.992 s, System: 0.687s]
  Range (min … max):    2.749 s …  3.287 s    10 runs

@rgrinberg rgrinberg merged commit 6509b67 into main Jan 14, 2025
25 of 27 checks passed
@rgrinberg rgrinberg deleted the ps/rr/refactor_pkg___apply__talex5_optimization branch January 14, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant