make it that -custom-crt does not prevent linking with libcmt.lib #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But wouldn't it prevent linking with other variants of the C runtime? I would have expected that /nodefaultlib:LIBCMT doesn't hurt if libcmt.lib is passed explicitly. Is it an ordering problem between libraries? |
|
Err yeah indeed, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. #51
This does removes the addition of the
/nodefaultlib:LIBCMTin the command line when using the-custom-crtoption.With this, we can successfully link an OCaml program with LIBCMT by invoking ocamlopt with
-ccopt -custom-crt -cclib libcmt.lib(with a suitably compiled runtime library).fixes issue #51