Fix regression in construct test

ocaml · Dec 13, 2024 · 1ba5ae5 · 1ba5ae5
1 parent aa80995
commit 1ba5ae5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/ocaml/typing/typecore.ml b/src/ocaml/typing/typecore.ml
@@ -5804,6 +5804,8 @@ and type_construct env ~sexp lid sarg ty_expected_explained =
     | None -> Rejected
     | Some _ ->
       begin match sargs with
+      | [{pexp_desc = Pexp_extension ({ txt; _ }, _)}]
+          when txt = Ast_helper.hole_txt -> Required
       | [{pexp_desc =
             Pexp_ident _ |
             Pexp_record (_, (Some {pexp_desc = Pexp_ident _}| None))}] ->

diff --git a/tests/test-dirs/construct/c-inline-record-issue1617.t b/tests/test-dirs/construct/c-inline-record-issue1617.t
@@ -16,5 +16,8 @@
 
 Construct also works with inline records
   $ $MERLIN single construct -position 7:15 \
-  > -filename main.ml <main.ml | jq '.value[1]'
-  []
+  > -filename main.ml <main.ml | jq '.value[1]'  
+  [
+    "(Bar _)"
+  ]
+