Add -cmi-file to the ignored flags. Fixes #1703

ocaml · Nov 21, 2023 · fcc769f · fcc769f
1 parent f4ecb5c
commit fcc769f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/src/kernel/mconfig.ml b/src/kernel/mconfig.ml
@@ -427,7 +427,7 @@ let ocaml_ignored_parametrized_flags = [
   "-inline"; "-inline-prim-cost"; "-inline-toplevel"; "-intf";
   "-intf_suffix"; "-intf-suffix"; "-o"; "-rounds"; "-runtime-variant";
   "-unbox-closures-factor"; "-use-prims"; "-use_runtime"; "-use-runtime";
-  "-error-style"; "-dump-dir";
+  "-error-style"; "-dump-dir"; "-cmi-file";
 ]
 
 let ocaml_warnings_spec ~error =

diff --git a/tests/test-dirs/with-cmi.t b/tests/test-dirs/with-cmi.t
@@ -21,14 +21,7 @@ Since OCaml 5.1 the compiler support the -cmi-file flag:
 
   $ $OCAMLC -c -cmi-file main.cmi main.ml
 
-FIXME: Merlin should ignore the -cmi-file flag
+Merlin should ignore the -cmi-file flag
   $ $MERLIN single errors -cmi-file main.cmi -filename main.ml <main.ml |
   > jq '.value'
-  [
-    {
-      "type": "config",
-      "sub": [],
-      "valid": true,
-      "message": "unknown flag -cmi-file"
-    }
-  ]
+  []