Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.17 414 backport #1837

Merged
merged 24 commits into from
Sep 26, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
3b91b41
[B] SOURCE_ROOT, UNIT_NAME and WRAPPING_PREFIX
voodoos Sep 25, 2024
b52d18d
[B] #1795: Fix #1794: Add `-unboxed-types` and `-no-unboxed-types` to…
voodoos Sep 25, 2024
c02a023
[B] #1804 vim: remove references to MerlinPhrase
voodoos Sep 25, 2024
140bb29
[B] #1806 Ignore new Menhir deprecations
voodoos Sep 25, 2024
d0b018d
[B] #1800 Refinement in the presence of optional arguments
voodoos Sep 25, 2024
1f57d7f
[B] #1807 Check always that default args are option
voodoos Sep 25, 2024
463eb71
[B] #1803 Fix ignorance of STDLIB in .merlin
voodoos Sep 25, 2024
2b01e1f
[B] #1745 Expand PPX nodes
voodoos Sep 25, 2024
e1ef844
[B] #1810 Produce a better error message when a flag spec appears mul…
voodoos Sep 25, 2024
d7968d6
[B] #1812 Inlay hint upstreaming
voodoos Sep 25, 2024
3b7f685
[B] #1814 Some UI improvement for `emacs/merlin-search`
voodoos Sep 25, 2024
198d6f5
[B] #1811 Exposes some helper for reducing direct typedtree usage in Lsp
voodoos Sep 25, 2024
db0b37e
[B] #1720 Signature Help
voodoos Sep 25, 2024
681c3c8
Compat with new occurrences api
voodoos Sep 25, 2024
83efbfa
Setup codebase formatting and fix a few comments.
voodoos Sep 25, 2024
e6786db
Format the codebase
voodoos Sep 25, 2024
c6fb925
Add commit to ignored revs
voodoos Sep 25, 2024
19e7220
[B] #1828 Search by type feature, a kind of sherlodoc in Merlin
voodoos Sep 25, 2024
c83e2e3
Promote fixed test after Dune upgrade
voodoos Sep 25, 2024
dc5e372
Silence ld warnings in tests
voodoos Sep 25, 2024
c04d859
Enable github CI
voodoos Sep 25, 2024
b82b038
[B] #1839 Fix ignorance of SOURCE_ROOT directive
voodoos Sep 25, 2024
98616bd
Make deps explicit
patrick-nicodemus Sep 25, 2024
315ccfa
[B] #1841 Document missing commands in PROTOCOL.md
voodoos Sep 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[B] #1795: Fix #1794: Add -unboxed-types and -no-unboxed-types to…
… ignored flags
voodoos committed Sep 25, 2024
commit b52d18df662ca6b83cfc9df4ec3aa6501e4e460e
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ unreleased
+ merlin binary
- A new `WRAPPING_PREFIX` configuration directive that can be used to tell Merlin
what to append to the current unit name in the presence of wrapping (#1788)
- Add `-unboxed-types` and `-no-unboxed-types` as ocaml ignored flags (#1795, fixes #1794)
+ editor modes
- vim: fix python-3.12 syntax warnings in merlin.py (#1798)

8 changes: 4 additions & 4 deletions src/kernel/mconfig.ml
Original file line number Diff line number Diff line change
@@ -430,10 +430,10 @@ let ocaml_ignored_flags = [
"-noautolink"; "-no-check-prims"; "-nodynlink"; "-no-float-const-prop";
"-no-keep-locs"; "-no-principal"; "-no-rectypes"; "-no-strict-formats";
"-no-strict-sequence"; "-no-unbox-free-vars-of-clos";
"-no-unbox-specialised-args"; "-O2"; "-O3"; "-Oclassic"; "-opaque";
"-output-complete-obj"; "-output-obj"; "-p"; "-pack";
"-remove-unused-arguments"; "-S"; "-shared"; "-unbox-closures"; "-v";
"-verbose"; "-where";
"-no-unbox-specialised-args"; "-no-unboxed-types"; "-O2"; "-O3";
"-Oclassic"; "-opaque"; "-output-complete-obj"; "-output-obj"; "-p"; "-pack";
"-remove-unused-arguments"; "-S"; "-shared"; "-unbox-closures";
"-unboxed-types"; "-v"; "-verbose"; "-where";
]

let ocaml_ignored_parametrized_flags = [
13 changes: 13 additions & 0 deletions tests/test-dirs/errors/issue1794.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
$ $MERLIN single errors -filename main.ml -unboxed-types
{
"class": "return",
"value": [],
"notifications": []
}

$ $MERLIN single errors -filename main.ml -no-unboxed-types
{
"class": "return",
"value": [],
"notifications": []
}