-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[503] Project-wide renaming #1877
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
art-w
reviewed
Dec 20, 2024
voodoos
force-pushed
the
503-renaming
branch
from
December 20, 2024 16:28
01c1bb0
to
f211402
Compare
voodoos
force-pushed
the
503-renaming
branch
from
December 20, 2024 16:31
7e10b7e
to
2ebcb21
Compare
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
Dec 20, 2024
xvw
reviewed
Jan 6, 2025
xvw
reviewed
Jan 6, 2025
xvw
approved these changes
Jan 6, 2025
Co-authored-by: art-w <[email protected]> Refactors suggested-by: xvw <[email protected]>
when in the new "renaming" scope Refactors suggested-by: xvw <[email protected]>
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jan 10, 2025
CHANGES: Fri Jan 10 17:55:42 CET 2025 + merlin binary - Support for OCaml 5.3 - Use new 5.3 features to improve locate behavior in some cases. Merlin no longer confuses uids from interfaces and implementations. (ocaml/merlin#1857) - Perform less merges in the indexer (ocaml/merlin#1881) - Add initial support for project-wide renaming: occurrences can now return all usages of all related definitions. (ocaml/merlin#1877) + vim plugin - Added support for search-by-type (ocaml/merlin#1846) This is exposed through the existing `:MerlinSearch` command, that switches between search-by-type and polarity search depending on the first character of the query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for project-wide Renaming:
occurrences
with the new scopeRenaming
, Merlin will return all the usages of the definition corresponding to the selected identifier, all the declarations/definitions linked to that definition and all the usages of all these definitions.This PR is based on #1857
Todo