Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookbook database recipes #2376

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Cookbook database recipes #2376

wants to merge 6 commits into from

Conversation

cuihtlauac
Copy link
Collaborator

Adapted from @F-Loyer recipes

Base automatically changed from cookbook to main May 6, 2024 13:42
@sabine sabine changed the title Rebased database recipes (needs rebase)\ database recipes May 9, 2024
@cuihtlauac cuihtlauac changed the title (needs rebase)\ database recipes Cookbook: database recipes May 13, 2024
@cuihtlauac cuihtlauac changed the title Cookbook: database recipes Cookbook database recipes May 13, 2024
Copy link
Collaborator

@christinerose christinerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my changes to ensure they're all still accurate.

Also, in li 49, the sentence "Then when this query is called, () is returned (Ok () to be accurate)" is confusing.

"() is returned" — that's clear, but "Ok () to be accurate" confuses me. If Ok() is more accurate, would it be better just to say "Then when this query is called, Ok () is returned"?

@F-Loyer
Copy link
Contributor

F-Loyer commented Jul 10, 2024

Please review my changes to ensure they're all still accurate.

Also, in li 49, the sentence "Then when this query is called, () is returned (Ok () to be accurate)" is confusing.

"() is returned" — that's clear, but "Ok () to be accurate" confuses me. If Ok() is more accurate, would it be better just to say "Then when this query is called, Ok () is returned"?

Yes... "Then when this query is called, Ok () is returned"? would be better.

@christinerose
Copy link
Collaborator

Yes... "Then when this query is called, Ok () is returned"? would be better.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants