Some minor fixes #1271
Merged
Some minor fixes #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonludlam
force-pushed
the
further-voodoo-tweaks-v2
branch
from
cc59c8a to
639c014
Compare
jonludlam
added
the
no changelog
This commit changes a couple of 'hard errors' -- assert failures -- into something that still not correct, but at least outputs something.
For example, in coq.8.10.0
The problem here is hidden when the odoc and odocl directories are the same, which is the default in odoc_driver.
jonludlam
force-pushed
the
further-voodoo-tweaks-v2
branch
from
639c014 to
f6e8fe0
Compare
Julow
reviewed
Jan 13, 2025
| { Loc.line; column } | ||
| with _ -> | ||
| (* Presumably this is the above-mentioned bug that's being hit. *) | ||
| { Loc.line = -1; column = -1 } |
There was a problem hiding this comment.
The only thing that raises a Invalid_argument is the array access at line 68. I think this could be handled better. It's also possible that locator is not computed right by massage_comment as it's so complicated.
There was a problem hiding this comment.
There's quite a lot we can do with the markdown code, but I don't want to spend too much time on it until I'm sure people want it and are using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #1270