Hygiene tests: don't duplicate compilation units #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Cc @dra27, which is the original author for this test.) |
|
Thanks! There is indeed no need for the |
|
Ok, I updated the PR to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test added in #43 creates a binary with conflicting compilation units. In particular,
OpamBaseParseris both present in theopamFileFormatlibrary and on the command line, and it is only by sheer luck that the compiler manages to not complain about that (Flambda 2 does actually complain about that).My proposed fix is to use a different name, but my reading of the
dunefile also suggests that maybe linking with the library wasn't intended.We're going to have to patch Flambda 2 anyway, as the same problems arise in more complicated situations, but I think this PR is a good improvement on its own.