-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ez_opam_file.0.1.0 compatibility package for opam-file-format #17779
Conversation
1cc7b9e
to
0260909
Compare
This package is fine by me of course, but can we just fix this in opam-file-format @rjbou? A point release (2.1.1) shouldn't be incompatible with the previous one (2.1.0). |
They are not incompatible, a lot of deprecated functions in 2.1.1, but still available and usable. |
Is it possible to switch this discussion to |
I would rather prefer not to merge this PR and temporary merge #17788 instead. Is that ok for you? |
The description is misleading - This package therefore back-ports new features in opam-file-format 2.1.1 to 2.1.0. I have no issue with that, but I wonder if @kit-ty-kate's idea combined with opam-file-format 2.1.2 would mean this library wouldn't be wanted for drom? As to why we compatibly (in the limited OCaml definition!) added new features to a point release, we made a mistake releasing opam-file-format 2.1.0 before opam 2.1.0 itself. The alternative is to have opam 2.1 depend on opam-file-format 2.2 which I think is even more weird than our small semver violation! |
Whatever happens with Note that, in my own recent packages, I use a convention to put the interface in a |
The mistake's been made with opam-file-format, so we should unblock @lefessan with this (independent) package. I'm going ahead and merging this, and opam-file-format can be fixed elsewhere indeed. |
Thanks @avsm ! |
opam-file-format 2.1.1 is incompatible with previous versions. This package provides a (minimal, for now) compatibility layer that allows
drom
andopam-bin
to be installed with any version of opam-file-format.