Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA: Add OCaml 5.3 to the build matrix #6192

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

GHA: Add OCaml 5.3 to the build matrix #6192

wants to merge 3 commits into from

Conversation

kit-ty-kate
Copy link
Member

Split off from #6189 as OCaml 5.3 is not released yet and contains several issues such as incompatibility with C++ (ocaml/ocaml#13422) and Cygwin (ocaml/ocaml#13421)

@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Sep 5, 2024
@kit-ty-kate kit-ty-kate mentioned this pull request Sep 5, 2024
Merged
@dra27
Copy link
Member

dra27 commented Sep 10, 2024

Why are we dropping i686 builds completely? I can't remember - do the Linux builds use opam to create the compiler switches, or did we optimise it with a system compiler?

This was referenced Sep 25, 2024
Closed
Merged
@kit-ty-kate kit-ty-kate changed the title GHA: Use both 4.14 and 5.3 as default version, remove i686 from the build matrix and add 5.2 GHA: Add OCaml 5.3 to the build matrix Oct 10, 2024
@kit-ty-kate kit-ty-kate marked this pull request as ready for review January 8, 2025 22:57
@kit-ty-kate
Copy link
Member Author

@dra27 @MisterDA do you have an idea what's wrong with the cygwin port with 5.3.0?

  ** Cannot resolve symbols for descriptor object:
   _ZTH10caml_state
  File "caml_startup", line 1:
  Error: Error during linking (exit code 2)

@kit-ty-kate
Copy link
Member Author

ocaml/ocaml#13591 was supposed to fix this issue (ocaml/ocaml#13541) but it doesn't look like it did

@kit-ty-kate
Copy link
Member Author

cc @NickBarnes as well just in case since you also reviewed that PR

@kit-ty-kate kit-ty-kate requested a review from dra27 January 9, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dra27 dra27 Awaiting requested review from dra27

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
AREA: BUILD AREA: PORTABILITY AREA:TEST
Projects
None yet
Milestone
2.4.0~alpha1
Development

Successfully merging this pull request may close these issues.
2 participants
@kit-ty-kate @dra27