Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the right versions of packages are used when simulating pinning #6256

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Oct 22, 2024

This PR is queued on top of #6209
The current title is temporary while i'm trying to understand what is the cause of the bug

I'm really confused as to what is making the made-up test work just fine but the test with goblint fail.
I'd like to understand what is making opam get almost all the dependencies but miss ppx_blob in the first deps-only install.
Ideally once we understand what's happening we should be able to build a dedicated test and remove the one relying on opam-repository

Fixes #6379
Fixes #6248

@kit-ty-kate kit-ty-kate added KIND: BUG AREA: ENGINE PR: QUEUED Pending pull request, waiting for other work to be merged or closed labels Oct 22, 2024
@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Oct 22, 2024
@kit-ty-kate kit-ty-kate added the PR: WIP Not for merge at this stage label Oct 28, 2024
@kit-ty-kate kit-ty-kate force-pushed the fix-opam-install-local-pinned-known-pkgs branch from 7f616a2 to 724ac4c Compare February 22, 2025 13:08
@kit-ty-kate kit-ty-kate removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Feb 22, 2025
@kit-ty-kate kit-ty-kate changed the title Fix #6248 Ensure the right versions of packages are used when simulating pinning Feb 22, 2025
@rjbou rjbou force-pushed the fix-opam-install-local-pinned-known-pkgs branch from 724ac4c to 4bef915 Compare February 25, 2025 16:06
@rjbou rjbou self-requested a review February 25, 2025 16:14
@kit-ty-kate kit-ty-kate force-pushed the fix-opam-install-local-pinned-known-pkgs branch from 4bef915 to 5a93cc3 Compare February 25, 2025 20:30
@kit-ty-kate kit-ty-kate added PR: QUEUED Pending pull request, waiting for other work to be merged or closed and removed PR: WIP Not for merge at this stage labels Feb 25, 2025
@kit-ty-kate kit-ty-kate force-pushed the fix-opam-install-local-pinned-known-pkgs branch from 5a93cc3 to f9bdd4f Compare March 1, 2025 20:18
@kit-ty-kate kit-ty-kate removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Mar 1, 2025
@kit-ty-kate kit-ty-kate force-pushed the fix-opam-install-local-pinned-known-pkgs branch from f9bdd4f to 0e0eb5f Compare March 1, 2025 20:22
@kit-ty-kate kit-ty-kate marked this pull request as ready for review March 1, 2025 20:22
@kit-ty-kate kit-ty-kate force-pushed the fix-opam-install-local-pinned-known-pkgs branch from 0e0eb5f to 31218de Compare March 1, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants