Fix UI glitches and do not pre-write the answer to questions with the default anwser #6290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
fix-opamconsole-pause
branch
from
668b1b4 to
57cf486
Compare
rjbou
reviewed
Nov 27, 2024
| @@ -824,12 +824,13 @@ let confirm ?(require_unsafe_yes=false) ?(default=true) fmt = | |||
| then | |||
| (formatted_msg "%sn\n" prompt; false) | |||
| else | |||
| short_user_input ~prompt ~default:(if default then "y" else "n") | |||
| short_user_input ~prompt ~default:' ' | |||
There was a problem hiding this comment.
What is the reason behind removing the pre-written answer?
There was a problem hiding this comment.
The reason is that it is more standard and expected from regular unix users. All the commands with interactive y/n questions i can think of do this
There was a problem hiding this comment.
Fair enough, i don't have a strong opinion on that :) lgtm
rjbou
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queued on top of #6289This implements what was described in #6289 (review) with the addition of a UI bugfix:
In this example you can see the
Press enter ...line is missing the end of line character. This happens becauseOpamConsole.pause(used to write this line) usesshort_user_inputwith~default:"", but this function wasn't made to have its default be anything but a string of length 1 in interactive mode. This is marked evident as the prompt subfunction will move the cursor left then remove one character, which happens to be the issue here.