Remove ocaml-system from the list of default compilers used during opam init #6307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussion on dev meeting: For a transition phase, we should detect presence of a system ocaml and display a hint for the command to run to have by default ocaml-system. |
rjbou
reviewed
Nov 25, 2024
| @@ -116,36 +116,23 @@ Configuring from ${BASEDIR}/opamrc and then from built-in defaults. | |||
| <><> Fetching repository information ><><><><><><><><><><><><><><><><><><><><><> | |||
| [default] Initialised | |||
|
|
|||
| <><> Creating initial switch 'default' (invariant ["ocaml" {>= "4.05.0"}] - initially with ocaml-system) | |||
There was a problem hiding this comment.
This test needs to be fixed with the new behaviour (add -c ocaml-system), and another one added for the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3509
I don't think having
ocaml-systemin the list of default compiler is a good choice.Most platforms actually won't work if you installed the
ocamlpackage alone. They usually all require some sort of extraocaml-compiler-libsto be complete and not end up in very confusing error messages for new users.System compilers are also not tested in the CI for opam-repository as of today (see ocurrent/opam-repo-ci#327) and end up breaking packages from time to time.
Experienced developers can always use
opam init -c ocaml-systemif they really want a system compiler andocaml-systemcan always be installed explicitly later if needed, but as a default for everyone it seems to brittle to me.