Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Books section #1579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved Books section #1579

wants to merge 1 commit into from

Conversation

Riddhima23
Copy link
Contributor

Issue Description

The Books section was disorganised with irregularities in alignment of text with pictures and spacing between rows.

Before:

1
3
5
6
7

final_6075112b445d0500ad3bd6b1_157559_Trim.mp4

Fixes #1403

Changes Made

Aligned the text and images and fixed the spacing issue between two books.

After:

1-a
3-a
5-a
6-a
7-a

final_607510bd42ef460069abda5a_45834_Trim.mp4
  • Please check if the PR fulfills these requirements
  • PR is descriptively titled and links the original issue above
  • Before/after screenshots (if this is a layout change)
  • Details of which platforms the change was tested on (if this is a browser-specific change)
  • Context for what motivated the change (if this is a change to some content)

@patricoferris
Copy link
Contributor

Hi @Riddhima23 this looks good thanks. I'm wondering if some of the styling can't be extracted into a class at this point to avoid all of the duplication in the style attributes?

@Riddhima23
Copy link
Contributor Author

Hi @patricoferris! Sincere apologies for replying late! Could you please elaborate a bit on the question, do you want there should be some div class wherein style attributes are given and I should just include that class in every image tag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizing books.html page
2 participants