Add empty action, only tell user they can connect if podman build worked #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowertree
changed the title
BartMassey
reviewed
Jun 1, 2024
BartMassey
approved these changes
Jun 1, 2024
|
The empty state “” is passed when loading weboccam.cgi with no arguments, which is what happens when you click in from the “Run Occam” link on index.html. Without this change, that transition into the radio button selection form produces an actionError that prevents loading the selection of radio buttons for choosing how to build the rest of the form. I am not positive but believe this empty state is used as an implicit “home” or similar action. A better fix long term might be to make it explicit.
The second part is just cosmetic/accurate for the build script completion.
…On Sat, Jun 1, 2024 at 12:00 AM, Bart Massey ***@***.***(mailto:On Sat, Jun 1, 2024 at 12:00 AM, Bart Massey <<a href=)> wrote:
@BartMassey commented on this pull request.
What's up with this? Can you provide more detail?
—
Reply to this email directly, [view it on GitHub](#76 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AW3O7LOFXXSIBDD7A5Q6GSLZFFWQDAVCNFSM6AAAAABITWU26CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOJSGAZTQMBQHE).
You are receiving this because you were assigned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't tell users it worked if it didn't