fix return_one_result flag not return one result #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenyunlong
reviewed
Mar 11, 2024
| if (returnOneResult) { | ||
| if (results[0] == null) { | ||
| results[0] = new ObTableOperationResult(); | ||
| } |
There was a problem hiding this comment.
need to accumulate affected_rows when the table operation spans two or more tablet
shenyunlong
reviewed
Mar 11, 2024
| } | ||
| ObTableOperationType lastType = operations.get(0).getOperationType(); | ||
| if (returnOneResult | ||
| && !(batchOperation.isSameType() && (lastType == ObTableOperationType.INSERT |
There was a problem hiding this comment.
can we move this defensive code to the interface layer, which will be more readable?
shenyunlong
approved these changes
Mar 13, 2024
WeiXinChan
added a commit
that referenced
this pull request
Mar 25, 2024
* 增加same_property_names判断 (#79) * properties name ignor case --------- Co-authored-by: wumengjie.wmj <[email protected]> * support put operation (#80) * add option flag, batch operations can return one res (#94) * fix test case, in return one result (#97) * add option flag, batch operations can return one res * fix return one result test * add tests (#103) * support batch put (#107) * fix batch put use correct api (#108) * support batch put * fix batch put use put method * atomic can across partition * [Feat] batchOperation support LSOp (#105) * [Feat] support LS batch routing * [Feat] single operation adapt to ObTableLSOp * [Test] add test for LS batch * [Enhancement] add get operation test for LsOp and fix bugs * [Test] add test cases for ObTableLSOp * [Test] add batch put test for ObTableLSOp * [Fix] add defensive code to disallow mix checkAndInsUp and other types operation * [OBKV] ObTableLsOp adapt to returnOneResult * [Fix] modify accord to review * fix return_one_result flag not return one result (#110) * fix return_one_result flag not return one result * fix review * [Fix] adapt to lob-related table object type (#113) * [Fix] adapt to lob-related table object type * [Fix] set ObLsOp tableName for ODP mode * Fix prv tenantid always 1 (#114) * fix prv_tenantid always 1 * add BatchGet test case * [Fix] isSamePropertiesNames flag is wrong in ObTableTabletOp (#118) * fix review comment --------- Co-authored-by: eemjwu <[email protected]> Co-authored-by: wumengjie.wmj <[email protected]> Co-authored-by: xiaoai <[email protected]> Co-authored-by: Shen Yunlong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix return_one_result flag not return one result
Solution Description
When returning the package, merge the results of each partition.