[Feat] support checkAndInsUp #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenyunlong
force-pushed
the
master
branch
2 times, most recently
from
de7c7f9 to
e2848be
Compare
IHEII
reviewed
Jan 4, 2024
src/main/java/com/alipay/oceanbase/rpc/checkandmutate/CheckAndInsUp.java
Show resolved
Hide resolved
src/main/java/com/alipay/oceanbase/rpc/mutation/BatchOperation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableLSOpFlag.java
Show resolved
Hide resolved
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableLSOpRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableLSOpResult.java
Outdated
Show resolved
Hide resolved
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableTabletOp.java
Outdated
Show resolved
Hide resolved
...ava/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/mutate/ObTableQueryAndMutate.java
Outdated
Show resolved
Hide resolved
src/main/java/com/alipay/oceanbase/rpc/table/ObTableClientLSBatchOpsImpl.java
Show resolved
Hide resolved
IHEII
reviewed
Jan 4, 2024
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableTabletOp.java
Outdated
Show resolved
Hide resolved
IHEII
reviewed
Jan 4, 2024
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableLSOperation.java
Show resolved
Hide resolved
IHEII
reviewed
Jan 4, 2024
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableLSOpRequest.java
Outdated
Show resolved
Hide resolved
IHEII
reviewed
Jan 4, 2024
IHEII
reviewed
Jan 5, 2024
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTabletOpResult.java
Outdated
Show resolved
Hide resolved
shenyunlong
force-pushed
the
master
branch
2 times, most recently
from
b3b3b7a to
6d6fe60
Compare
IHEII
reviewed
Jan 8, 2024
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableLSOperation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableSingleOp.java
Outdated
Show resolved
Hide resolved
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableTabletOp.java
Outdated
Show resolved
Hide resolved
src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableTabletOpFlag.java
Outdated
Show resolved
Hide resolved
|
LGTM |
eemjwu
pushed a commit
to eemjwu/obkv-table-client-java
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this pull request, We implemented a new interface checkAndInsUp, which means that insert up operations are performed only if the check is successful, and this interface is useful in some cases, such as asynchronous log synchronization in different clusters, need to check the timestamp of the data, and only allow newer operations to be performed.
Solution Description
We added some flags in obTableQueryAndMutate and reused this rpc message to pass the check and execute semantics, and the obkv server will perform this rpc call and return a response to the client. In addition, in order to support batch checking and modification and improve throughput, we implement a new batch rpc message format ObTableLSOpRequest.