Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-17637923 fix: include nodeOptions in win installer bin #1672

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

cristiand391
Copy link
Member

Fixes: forcedotcom/cli#3161

The windows tarball bin gets CLI's node options in the cmd file:

node ${`${nodeOptions.join(' ')} `}"%~dp0..\\bin\\run" %*

the installer one doesn't:

"%~dp0\\..\\client\\bin\\node.exe" "%~dp0\\..\\client\\${

@W-17637923@

@cristiand391 cristiand391 marked this pull request as ready for review January 21, 2025 15:21
@cristiand391
Copy link
Member Author

QA notes:

Triggered an sf prerelease with this branch of oclif:
https://github.com/salesforcecli/cli/releases/tag/2.73.8-dev.0

before

ignore the cat ... above sf org list auth, that's not the cmd file
20250121_115523

after

20250121_115639

@mdonnalley mdonnalley merged commit 247de97 into main Jan 21, 2025
7 checks passed
@mdonnalley mdonnalley deleted the cd/windows-node-opts branch January 21, 2025 15:40
@iowillhoit iowillhoit changed the title fix: include nodeOptions in win installer bin W-17637923 fix: include nodeOptions in win installer bin Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants