Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Logging e2e testcases #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for Logging e2e testcases #82

wants to merge 1 commit into from

Conversation

Jeevaann
Copy link

No description provided.

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jeevaann
Once this PR has been reviewed and has the lgtm label, please assign pravin-dsilva for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot
Copy link
Contributor

Welcome @Jeevaann! It looks like this is your first PR to ocp-power-automation/ocp4-playbooks-extras 🎉

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 23, 2024
@varad-ahirwadkar
Copy link
Contributor

varad-ahirwadkar commented Oct 1, 2024 •
edited
Loading

Hi @Jeevaann, Can you please squash the commits? And these commit contains changes for playbooks/roles/ocp-e2e/tasks/main.yml.

Also please add new line at end of the files.

@Jeevaann
Copy link
Author

Hi @Jeevaann, Can you please squash the commits? And these commit contains changes for playbooks/roles/ocp-e2e/tasks/main.yml.

Also please add new line at end of the files.

Yes, I have squashed the commits and also added new line at the end of the files. This is all together a new playbook which will run logging e2e testcases from openshift-test-private repo.

@Jeevaann Jeevaann force-pushed the logging-e2e branch 2 times, most recently from 0026fd1 to 086322f Compare October 14, 2024 14:25
@ppc64le-cloud-bot ppc64le-cloud-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravin-dsilva pravin-dsilva Awaiting requested review from pravin-dsilva

@yussufsh yussufsh Awaiting requested review from yussufsh

@varad-ahirwadkar varad-ahirwadkar Awaiting requested review from varad-ahirwadkar

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jeevaann @ppc64le-cloud-bot @varad-ahirwadkar