Create Playbook for developing and testing sample helm based operator using operator-sdk #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SurajGudaji The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ator using operator-sdk Signed-off-by: SurajGudaji <[email protected]>
ppc64le-cloud-bot
added
the
size/L
yussufsh
reviewed
Nov 15, 2024
| - name: Validate Operator development and installation | ||
| include_role: | ||
| name: ocp-operator-api | ||
|
|
There was a problem hiding this comment.
please remove the space char.
yussufsh
requested changes
Nov 15, 2024
|
|
||
| - Login to a quay.io account | ||
| ``` | ||
| docker login -u='' -p='' quay.io |
There was a problem hiding this comment.
Suggested change
| docker login -u='' -p='' quay.io | |
| docker login -u='<quay_username>' -p='<quay_password>' quay.io |
| |--------------------------------------------|----------|--------------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------| | ||
| | op_api_role_enable | no | false | Set it to true to run this playbook | | ||
| | op_cleanup | no | false | Set it to true to do operator cleanup. | | ||
| | build_operator_image | no | true | Set it to true to build the operator image | |
There was a problem hiding this comment.
Since the default is true.
Suggested change
| | build_operator_image | no | true | Set it to true to build the operator image | | |
| | build_operator_image | no | true | Set it to false to not build the operator image | |
Comment on lines
+9
to
+10
| ocp_version: "418" | ||
| quay_username: "" |
There was a problem hiding this comment.
- These are marked as required, so don't set in defaults.
- Setting empty
quay_usernamedoes not make sense, won't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.